Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nacos客户端磁盘降级需求 issues:11053 #11207

Merged
merged 32 commits into from
Dec 5, 2023

Conversation

guozongkang
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

#11053

Brief changelog

1.使用磁盘来实现Nacos客户端降级方案
2.可以修改机器上的文件,开启或关闭降级,并且指定需要降级的服务
3.查询机器列表时,优先走降级逻辑

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2023

CLA assistant check
All committers have signed the CLA.

nkorange
nkorange previously approved these changes Oct 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2023

Codecov Report

Merging #11207 (de60b8a) into develop (76861a9) will increase coverage by 6.18%.
Report is 84 commits behind head on develop.
The diff coverage is 27.02%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11207      +/-   ##
=============================================
+ Coverage      54.06%   60.25%   +6.18%     
- Complexity      5509     5854     +345     
=============================================
  Files            893      892       -1     
  Lines          28525    26914    -1611     
  Branches        3160     2765     -395     
=============================================
+ Hits           15423    16217     +794     
+ Misses         11757     9584    -2173     
+ Partials        1345     1113     -232     
Files Coverage Δ
...ba/nacos/client/naming/backups/FailoverSwitch.java 66.66% <66.66%> (ø)
...acos/client/naming/backups/NamingFailoverData.java 0.00% <0.00%> (ø)
...libaba/nacos/client/naming/utils/CacheDirUtil.java 50.00% <50.00%> (ø)
...libaba/nacos/client/naming/NacosNamingService.java 87.41% <60.00%> (-3.32%) ⬇️
...a/nacos/client/naming/cache/ServiceInfoHolder.java 77.98% <55.00%> (+0.78%) ⬆️
...baba/nacos/client/naming/backups/FailoverData.java 0.00% <0.00%> (ø)
...a/nacos/client/naming/backups/FailoverReactor.java 36.00% <22.66%> (-0.37%) ⬇️
...ing/backups/datasource/DiskFailoverDataSource.java 13.69% <13.69%> (ø)

... and 163 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76861a9...de60b8a. Read the comment docs.

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be merged after 2.3.0 released.

@KomachiSion KomachiSion added the kind/feature type/feature label Dec 5, 2023
@KomachiSion KomachiSion added this to the 2.3.1 milestone Dec 5, 2023
@KomachiSion KomachiSion merged commit 380c019 into alibaba:develop Dec 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants